Some advice on a custom Trait