[Python] Replacing a method from the decorator_career_gig

Thank so much o19! Your suggestion of logging it's honestly great, I'm so used to tuning files that I forgot I'm actually writing on Python, where I can tell my mod to generate a log file. :P

Now, injecting in tuning mods means that you will add a new piece of code whenever a method is called (injecting an affordance means that whenever the "affordances" method is called, the newer piece of code you added will also be executed) but I'm not sure if I want to do that, specially after reading what Deaderpool wrote.

To be clear what I want to do is this

1) In EA's files, there is a "calculate_gig_result" method that references the "get_gig_score_for_preferences" method.
2) Since I want the "calculate_gig_result" to have a diferent result, I'm working on the "get_gig_score_for_preferences" method.
3) What I want to do is that whenever the "get_gig_score_for_preferences" gets called, my newer "_custom_get_gig_score_for_preferences" is called instead. Which means that I need to overwrite the function completely. I don't want to add another method, I want to overwrite the original one (the mod I want to create is for personal use)

Now, from what I understood, Deaderpool only gives examples on how to "hook" your piece of code to an already existing method.Meaning that if a function called "EA's_Code" runs, what you do inside the injector will be "added_up" as a part of the already existing method. What I want to do is that whenever the "EA's_Code" function gets called, my newer form of calculation gets called instead.

However, if I do something like this:

import careers.decorator_career_gig

@inject_to(careers.decorator_career_gig.DecoratorGig(ActiveGig), 'get_gig_score_for_preferences')
def custom_get_gig_score_for_preferences(original, self, preferences_list, likes_value, dislikes_value):
original(self, preferences_list, likes_value=1, dislikes_value=1)
final_value = -50000.

Since the "final_value" already exist on the original function, and my part of the code runs after that value is defined, when the original function returns the value, -50000 will returned instead of that the function calculated originally.. Am I right? Do I need to add the return too?

Or injection in script modding means that we will overwrite the whole method too but giving the possibility for other mods to use it? 

Edit: The cheat doesn't seem to be working. :(

Edit 2: I made the cheat work. However, it gives me this weird result:



I need to format it, right?

With s4cl you would simply add:
@commoninjectionutils.inject_safely_into(ModInfo.get_identity(), DecoratorGig, DecoratorGig.get_gig_score_for_preferences.__name__)
def do_get_gig_score_for_preference(original, self, *args, **kwargs):
# return original(self, *args, **kwargs)
return -600000
This would be your mod and as long as EA does not change their method names it'll work. Depending on your injection code it may be different but for me it's no joy to look into different inject and log options every time.

I'm sorry for the double posting, but I really want to thank you o19!




import sims4.commands

import careers

from functools import wraps

import build_buy,sims4.log

import traceback

import os.path

import inspect

from traits.trait_type import TraitType



@inject_to(careers.decorator_career_gig.DecoratorGig, 'get_gig_score_for_preferences')

def custom_get_gig_score_for_preferences(original, self, preferences_list, likes_value=1, dislikes_value=1, argument=1):

#original(self, preferences_list, likes_value, dislikes_value)

if argument == 1:

writelog("Argument 1")

return 0

else:

tags_modified = build_buy.get_gig_tag_changes(self._customer_lot_id)

likes_changes = 0

dislikes_changes = 0

traits_changes = 0

for preference_trait in preferences_list:

if preference_trait is None:

continue

tags = preference_trait.preference_item.get_any_tags()

if tags is not None:

for tag in tags:

tag_index = [i for i, v in enumerate(tags_modified) if v[0] == tag]

if len(tag_index) > 0:

if preference_trait.trait_type == TraitType.LIKE:

likes_changes += tags_modified[tag_index[0]][1]

elif preference_trait.trait_type == TraitType.DISLIKE:

dislikes_changes += tags_modified[tag_index[0]][1]

else:

traits_changes += tags_modified[tag_index[0]][1]



likes_multiplier = 1

dislikes_multiplier = 1

traits_multiplier = 1

for score in self._decorator_gig_tuning.preference_scoring_weight:

if score.trait_type == TraitType.LIKE:

likes_multiplier = likes_changes * score.weight

elif score.trait_type == TraitType.DISLIKE:

dislikes_multiplier = dislikes_changes * score.weight

else:

traits_multiplier = traits_changes * score.weight



final_value = likes_multiplier * likes_value

final_value += dislikes_multiplier * dislikes_value

if traits_multiplier > 1:

final_value += traits_multiplier

writelog("Argument 2")

writelog(f" '{final_value}'.")

return final_value
This is part of the code I ended up using. As you can see, I even added a new parameter (argument), which I'm using to siwtch between cases and forms of calculation. 

Thanks to the logging files I could confirm this function was the one in charge to help the others and I also learnt that doing "-5000" was provoking other functions to receive an unexpected value. I needed to set the return to 0 to produce a failure outcome. 


Thank you so much for your patience! 


All I need to do now is to create a command that allow me to change  that argument parameter from an interaction (the same interaction used by EA to start the whole evaluation process), using a "do_command" method as a part of a tested outcome. 

Is it possible to create a command too? (and don't tell how to do it, I just need to know if that's possible, I have plenty of examples on how to do that and I don't want to bother you anymore)

I think at this point is fair to explain what I want to do:

Context

- The gig score calculation process is executed when the reveal ends (after the Sim goes "tadaaa"). In that moment, a tuning interaction executes a command as a part of its basic extras method, and starts the whole evalutation process right there.

What I want to do

1) Since I have way more experience creating tuning mods, I want to override that interaction (hopping that nobody else do it with a mod in the future haha ) to also include two tested outcomes:
a)The "normal" outcome where the normal process is executed.
b) The failure outcome, that will happen because in a specific gig you didn't add specific objects (let's say you forgot to add a shower in a bathroom renovation, well, you're screwed). This whole testing process is more comfortable in tuning files than in script.

2) The failure outcome then, will execute a "do_command" method, receiving an argument as a number.

3) In the script of the mod, I want to create a command that receives that number and then, switch the case to the failure one. In my overriden function, I want to set up a condition where, if the number is 1 (for example) then EA's Code run, if the number is other, then the failure outcome runs.

Now that you told me that what I wanted to do could fail, this is what I think my code will end up being:

import sims4.commands

import careers

from functools import wraps

import sims4.log

import traceback

import os.path

import inspect

switcher = 2

@sims4.commands.Command('careers.change_gig_outcome', command_type=sims4.commands.CommandType.Live)

def change_gig_outcome(input,_connection=None):

out = sims4.commands.CheatOutput(_connection)

global switcher

if input == 1:

switcher = 1

else:

switcher



@inject_to(careers.decorator_career_gig.DecoratorGig, 'get_gig_score_for_preferences')

def custom_get_gig_score_for_preferences(original, self, preferences_list, likes_value=1, dislikes_value=1):

global switcher

if switcher == 1:

# original(self, preferences_list, likes_value, dislikes_value)

writelog("Argument 1")

return 0

else:

original(self, preferences_list, likes_value, dislikes_value)

writelog("Argument 2")





Meaning that the global variable would have a default value, and the command should, for example, change the global variable to 1 to force a failure outcome. At the end, I will use the original function if the command doesn't change a thing. 


EDIT: How can I get final_value from the injector? 

OMG. I can't thank you enough o19! With you, I've lost my "fear" of scriptmodding. This is what my final main looks like now:

import sims4.commands
import careers
import injector
import sims4.log
import os.path

switcher = 1

#Utilities
def writelog(str, logname=None):
if logname is None:
logname = "Interior_Decorator_Overhaul.log"
filename = os.path.join(os.path.dirname(os.path.realpath(__file__)), logname)
with open(filename, "a") as fp:
fp.write('{}\n'.format(str))


#Actual code
#Command to change the outcome of the gig to a failure one
@sims4.commands.Command('careers.change_gig_outcome', command_type=sims4.commands.CommandType.Live)
def change_gig_outcome(input: int = 1, _connection=None):
global switcher
if input == 0:
switcher = 0
writelog("Failure outcome choosen")
else:
writelog("Normal outcome choosen")
switcher = 1


#Injector to override the function with my code
@injector.inject_to(careers.decorator_career_gig.DecoratorGig, 'get_gig_score_for_preferences')
def custom_get_gig_score_for_preferences(original, self, preferences_list, likes_value=1, dislikes_value=1):
global switcher
final_value = original(self, preferences_list, likes_value, dislikes_value)
final_value = final_value * switcher
writelog(f"Switcher current value is '{switcher}'.")
writelog(f"Final_Value current value is '{final_value}'.")
return final_value


It is so small, yet so powerful. I didn't even need to "override" the original code. Now I can properly say I did what I wanted to do. Now I just need S4S to get updated (I don't like using S4PE or XML Extractor Files) to put everything together! You're an angel.

And about the tests... I think in this case I'm gonna stick to tunning hahaha.